Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add count services, clients & test #1024

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Add count services, clients & test #1024

merged 3 commits into from
Oct 9, 2023

Conversation

leeminju531
Copy link
Contributor

this PR is for service counts using it's name like topic.
Related to ros2/ros2cli#771

Signed-off-by: leeminju531 dlalswn531@naver.com

@leeminju531 leeminju531 marked this pull request as ready for review October 8, 2022 14:26
@leeminju531 leeminju531 marked this pull request as draft October 17, 2022 01:00
@leeminju531 leeminju531 marked this pull request as ready for review December 12, 2022 02:15
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with minor comment.

rclpy/test/test_node.py Show resolved Hide resolved
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but may need to be rebased to pass CI.

Signed-off-by: leeminju531 <dlalswn531@naver.com>
Signed-off-by: leeminju531 <dlalswn531@naver.com>
Signed-off-by: leeminju531 <dlalswn531@naver.com>
@leeminju531
Copy link
Contributor Author

Cool. rebased:thumbsup:.

@clalancette
Copy link
Contributor

CI for this is in ros2/rclcpp#2072 (comment)

@clalancette clalancette merged commit e3d37c5 into ros2:rolling Oct 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants