Add on_parameter_event method to the AsyncParameterClient. #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This essentially is just a subscription to the /parameter_event topic, but makes it match the rclcpp API of the same name. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
requested review from
sloretz and
adityapande-1995
as code owners
fujitatomoya
approved these changes
Dec 23, 2022
|
CI:
|
|
The one failing test on Windows is a known flake. With that, and an approval, merging. Thanks for the review! |
delete-merged-branch
bot
deleted the
clalancette/add-on-parameter-event-callback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially is just a subscription to the /parameter_event topic, but makes it match the rclcpp API of the same name.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This should fix #1060