Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to timer.py #1260

Merged
merged 9 commits into from
Aug 5, 2024
Merged

Add types to timer.py #1260

merged 9 commits into from
Aug 5, 2024

Conversation

InvincibleRMC
Copy link
Contributor

No description provided.

fujitatomoya
fujitatomoya approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

rclpy/rclpy/timer.py Show resolved Hide resolved
@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

InvincibleRMC and others added 4 commits April 4, 2024 21:27
@InvincibleRMC
Add types to timer.py
bac0ce3 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@clalancette @InvincibleRMC
Small fixes for modern flake8. (ros2#1264)
1ef6614 
It doesn't like to compare types with ==, so switch to
isinstance as appropriate.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add types to time_source.py (ros2#1259)
5e808d2 
* Add types to time_source.py

Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Add TimerHandle docstring
c0e3e19 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@fujitatomoya
Copy link
Collaborator

@InvincibleRMC this seems including unrelated changes to this PR addressing? i think we need to rebase?

@InvincibleRMC
Copy link
Contributor Author

@InvincibleRMC this seems including unrelated changes to this PR addressing? i think we need to rebase?

Fixed.

@InvincibleRMC
Merge remote-tracking branch 'origin/rolling' into timer
b81a945
@InvincibleRMC
resolve merge conflicts
27daf2e 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Fix Callback input to be optional
c203838 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@sloretz
Copy link
Contributor

sloretz commented Aug 2, 2024

Pulls: #1260
Gist: https://gist.githubusercontent.com/sloretz/aa6a749969e857ad3679e52207a22b58/raw/39c151eb78f3400b4638d5c945527f1f70307654/ros2.repos
BUILD args: --packages-up-to rclpy
TEST args: --packages-select rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14357

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@sloretz sloretz merged commit 783d7d9 into ros2:rolling Aug 5, 2024
2 of 3 checks passed
@InvincibleRMC InvincibleRMC deleted the timer branch September 13, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@sloretz sloretz sloretz approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

Assignees

@fujitatomoya fujitatomoya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@InvincibleRMC @fujitatomoya @sloretz @clalancette