Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make publishers context-manager aware. #1289

Merged
merged 1 commit into from
May 31, 2024

Conversation

clalancette
Copy link
Contributor

The main reason to do this is so that we can change example code to use context managers for managing the lifetimes of publishers (and other entities), which should make the code significantly easier to read.

The main reason to do this is so that we can change example
code to use context managers for managing the lifetimes
of publishers (and other entities), which should make the
code significantly easier to read.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

I should mention that this partially fixes #1280 , though we'll need a bunch of other PRs before it is completely done.

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@ahcorde
Copy link
Contributor

ahcorde commented May 28, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 547245a into rolling May 31, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the clalancette/publisher-context-manager branch May 31, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants