Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust debug message that requested goal is already expired. #1363

Merged
merged 1 commit into from
Oct 8, 2024
Merged

adjust debug message that requested goal is already expired. #1363

merged 1 commit into from
Oct 8, 2024

Conversation

fujitatomoya
Copy link
Collaborator

closes #1236

@fujitatomoya
Copy link
Collaborator Author

@Barry-Xu-2018 could you take a look? just a minor comment and debug message fixes only.

CC: @ahcorde @clalancette

@Barry-Xu-2018
Copy link
Contributor

LGTM. This additional information can help users realize that they set the result timeout too short.

@fujitatomoya
Copy link
Collaborator Author

yes that is the only intention here. maybe we should escalate the log level from debug to warn?

@Barry-Xu-2018
Copy link
Contributor

yes that is the only intention here. maybe we should escalate the log level from debug to warn?

Totally agree. WARN is better.

@fujitatomoya
adjust warn message that requested goal is already expired.
e5fe615 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/action-result-responce-could-timeout branch from e2f5038 to e5fe615 Compare September 29, 2024 16:53
@fujitatomoya
Copy link
Collaborator Author

@ahcorde can you review this?

@ahcorde
Copy link
Contributor

ahcorde commented Oct 8, 2024

Pulls: #1363
Gist: https://gist.githubusercontent.com/ahcorde/2cc6dc1695be03f62d2c2596fd342ed0/raw/88045a1e37b059efb0c51c55b21b2814b123c1d1/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14679

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 4d7ff97 into rolling Oct 8, 2024
3 checks passed
@ahcorde ahcorde deleted the fujitatomoya/action-result-responce-could-timeout branch October 8, 2024 21:31
fujitatomoya added a commit to fujitatomoya/rclpy that referenced this pull request Oct 17, 2024
@fujitatomoya
Revert "adjust warn message that requested goal is already expired. (r…
14d3f44 
…os2#1363)"

This reverts commit 4d7ff97.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya mentioned this pull request Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@sloretz sloretz Awaiting requested review from sloretz

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError in ActionServer._execute_goal
3 participants
@fujitatomoya @Barry-Xu-2018 @ahcorde