Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adds types to Lifecycle Objects" #1373

Closed
wants to merge 1 commit into from

Conversation

fujitatomoya
Copy link
Collaborator

Reverts #1338

This re-generates the flaky for RHEL, see more details for ros2/ros2cli#932.

closes ros2/ros2cli#932

This reverts commit 2f9a771.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the revert-1338-TransitionCallbackReturn branch from 0c66993 to b2f1437 Compare October 14, 2024 15:22
@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Oct 14, 2024

CI (Full):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Linux-rhel-debug Build Status
  • Windows Build Status

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, assuming that Linux-rhel comes back green.

@fujitatomoya
Copy link
Collaborator Author

ros2cli test detected the segmentation fault as following.
which is really weird because what this revert PR changes is rclpy, and it breaks the ros2cli test. (we have met this before, ros2/ros2cli#932)

at least, this PR seems to fix original flaky reported https://ci.ros2.org/job/nightly_linux-rhel_release/2047/testReport/projectroot/test/test_graph__rmw_fastrtps_cpp/ in ros2/ros2cli#932 (comment)

maybe this segmentation fault is something else with RHEL.

stderr: ros2cli
--- stderr: ros2cli
10:57:41 Fatal Python error: Segmentation fault
10:57:41 
10:57:41 Current thread 0x00007f5211fa4740 (most recent call first):
10:57:41   File "/usr/lib/python3.9/site-packages/flake8_quotes/__init__.py", line 294 in __init__
10:57:41   File "/usr/lib/python3.9/site-packages/flake8_quotes/__init__.py", line 195 in <listcomp>
10:57:41   File "/usr/lib/python3.9/site-packages/flake8_quotes/__init__.py", line 195 in get_quotes_errors
10:57:41   File "/usr/lib/python3.9/site-packages/flake8_quotes/__init__.py", line 184 in run
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 500 in run_ast_checks
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 597 in run_checks
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 687 in _run_checks
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 48 in mapstar
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 125 in worker
10:57:41   File "/usr/lib64/python3.9/multiprocessing/process.py", line 108 in run
10:57:41   File "/usr/lib64/python3.9/multiprocessing/process.py", line 315 in _bootstrap
10:57:41   File "/usr/lib64/python3.9/multiprocessing/popen_fork.py", line 71 in _launch
10:57:41   File "/usr/lib64/python3.9/multiprocessing/popen_fork.py", line 19 in __init__
10:57:41   File "/usr/lib64/python3.9/multiprocessing/context.py", line 277 in _Popen
10:57:41   File "/usr/lib64/python3.9/multiprocessing/process.py", line 121 in start
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 326 in _repopulate_pool_static
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 303 in _repopulate_pool
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 212 in __init__
10:57:41   File "/usr/lib64/python3.9/multiprocessing/context.py", line 119 in Pool
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 664 in _try_initialize_processpool
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 260 in run_parallel
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 309 in run
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/main/application.py", line 271 in run_checks
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/api/legacy.py", line 109 in check_files
10:57:41   File "/home/jenkins-agent/workspace/ci_linux-rhel/ws/install/ament_flake8/lib/python3.9/site-packages/ament_flake8/main.py", line 281 in generate_flake8_report
10:57:41   File "/home/jenkins-agent/workspace/ci_linux-rhel/ws/install/ament_flake8/lib/python3.9/site-packages/ament_flake8/main.py", line 88 in main_with_errors
10:57:41   File "/home/jenkins-agent/workspace/ci_linux-rhel/ws/src/ros2/ros2cli/ros2cli/test/test_flake8.py", line 22 in test_flake8
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 183 in pytest_pyfunc_call
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 1641 in runtest
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 162 in pytest_runtest_call
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 255 in <lambda>
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 311 in from_call
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 254 in call_runtest_hook
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 215 in call_and_report
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 126 in runtestprotocol
10:57:41   File "/builddir/build/BUILDROOT/python-pytest-rerunfailures-9.1.1-3.el9.noarch/usr/lib/python3.9/site-packages/pytest_rerunfailures.py", line 240 in pytest_runtest_protocol
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 348 in pytest_runtestloop
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 323 in _main
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 269 in wrap_session
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 316 in pytest_cmdline_main
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/config/__init__.py", line 162 in main
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/config/__init__.py", line 185 in console_main
10:57:41   File "/usr/lib/python3.9/site-packages/pytest/__main__.py", line 5 in <module>
10:57:41   File "/usr/lib64/python3.9/runpy.py", line 87 in _run_code
10:57:41   File "/usr/lib64/python3.9/runpy.py", line 197 in _run_module_as_main
10:57:41 Fatal Python error: Segmentation fault
10:57:41 
10:57:41 Current thread 0x00007f5211fa4740 (most recent call first):
10:57:41   File "/usr/lib/python3.9/site-packages/flake8_quotes/__init__.py", line 189 in <listcomp>
10:57:41   File "/usr/lib/python3.9/site-packages/flake8_quotes/__init__.py", line 189 in get_noqa_lines
10:57:41   File "/usr/lib/python3.9/site-packages/flake8_quotes/__init__.py", line 181 in run
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 500 in run_ast_checks
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 597 in run_checks
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 687 in _run_checks
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 48 in mapstar
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 125 in worker
10:57:41   File "/usr/lib64/python3.9/multiprocessing/process.py", line 108 in run
10:57:41   File "/usr/lib64/python3.9/multiprocessing/process.py", line 315 in _bootstrap
10:57:41   File "/usr/lib64/python3.9/multiprocessing/popen_fork.py", line 71 in _launch
10:57:41   File "/usr/lib64/python3.9/multiprocessing/popen_fork.py", line 19 in __init__
10:57:41   File "/usr/lib64/python3.9/multiprocessing/context.py", line 277 in _Popen
10:57:41   File "/usr/lib64/python3.9/multiprocessing/process.py", line 121 in start
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 326 in _repopulate_pool_static
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 303 in _repopulate_pool
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 212 in __init__
10:57:41   File "/usr/lib64/python3.9/multiprocessing/context.py", line 119 in Pool
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 664 in _try_initialize_processpool
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 260 in run_parallel
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 309 in run
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/main/application.py", line 271 in run_checks
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/api/legacy.py", line 109 in check_files
10:57:41   File "/home/jenkins-agent/workspace/ci_linux-rhel/ws/install/ament_flake8/lib/python3.9/site-packages/ament_flake8/main.py", line 281 in generate_flake8_report
10:57:41   File "/home/jenkins-agent/workspace/ci_linux-rhel/ws/install/ament_flake8/lib/python3.9/site-packages/ament_flake8/main.py", line 88 in main_with_errors
10:57:41   File "/home/jenkins-agent/workspace/ci_linux-rhel/ws/src/ros2/ros2cli/ros2cli/test/test_flake8.py", line 22 in test_flake8
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 183 in pytest_pyfunc_call
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 1641 in runtest
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 162 in pytest_runtest_call
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 255 in <lambda>
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 311 in from_call
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 254 in call_runtest_hook
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 215 in call_and_report
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 126 in runtestprotocol
10:57:41   File "/builddir/build/BUILDROOT/python-pytest-rerunfailures-9.1.1-3.el9.noarch/usr/lib/python3.9/site-packages/pytest_rerunfailures.py", line 240 in pytest_runtest_protocol
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 348 in pytest_runtestloop
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 323 in _main
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 269 in wrap_session
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 316 in pytest_cmdline_main
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/config/__init__.py", line 162 in main
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/config/__init__.py", line 185 in console_main
10:57:41   File "/usr/lib/python3.9/site-packages/pytest/__main__.py", line 5 in <module>
10:57:41   File "/usr/lib64/python3.9/runpy.py", line 87 in _run_code
10:57:41   File "/usr/lib64/python3.9/runpy.py", line 197 in _run_module_as_main
10:57:41 
10:57:41 +++++++++++++++++++++++++++++++++++ Timeout ++++++++++++++++++++++++++++++++++++
10:57:41 
10:57:41 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Captured stderr ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
10:57:41 option --max-complexity: please update from optparse string `type=` to argparse callable `type=` -- this will be an error in the future
10:57:41 option --application-import-names: please update from optparse string `type=` to argparse callable `type=` -- this will be an error in the future
10:57:41 option --application-package-names: please update from optparse string `type=` to argparse callable `type=` -- this will be an error in the future
10:57:41 option --import-order-style: please update from optparse string `type=` to argparse callable `type=` -- this will be an error in the future
10:57:41 option --quotes: please update from optparse string `type=` to argparse callable `type=` -- this will be an error in the future
10:57:41 option --inline-quotes: please update from optparse string `type=` to argparse callable `type=` -- this will be an error in the future
10:57:41 option --multiline-quotes: please update from optparse string `type=` to argparse callable `type=` -- this will be an error in the future
10:57:41 option --docstring-quotes: please update from optparse string `type=` to argparse callable `type=` -- this will be an error in the future
10:57:41 
10:57:41 ~~~~~~~~~~~~~~~~~~~~~ Stack of Thread-28 (139988637292096) ~~~~~~~~~~~~~~~~~~~~~
10:57:41   File "/usr/lib64/python3.9/threading.py", line 937, in _bootstrap
10:57:41     self._bootstrap_inner()
10:57:41   File "/usr/lib64/python3.9/threading.py", line 980, in _bootstrap_inner
10:57:41     self.run()
10:57:41   File "/usr/lib64/python3.9/threading.py", line 917, in run
10:57:41     self._target(*self._args, **self._kwargs)
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 576, in _handle_results
10:57:41     task = get()
10:57:41   File "/usr/lib64/python3.9/multiprocessing/connection.py", line 254, in recv
10:57:41     buf = self._recv_bytes()
10:57:41   File "/usr/lib64/python3.9/multiprocessing/connection.py", line 418, in _recv_bytes
10:57:41     buf = self._recv(4)
10:57:41   File "/usr/lib64/python3.9/multiprocessing/connection.py", line 383, in _recv
10:57:41     chunk = read(handle, remaining)
10:57:41 
10:57:41 ~~~~~~~~~~~~~~~~~~~~~ Stack of Thread-27 (139988679255616) ~~~~~~~~~~~~~~~~~~~~~
10:57:41   File "/usr/lib64/python3.9/threading.py", line 937, in _bootstrap
10:57:41     self._bootstrap_inner()
10:57:41   File "/usr/lib64/python3.9/threading.py", line 980, in _bootstrap_inner
10:57:41     self.run()
10:57:41   File "/usr/lib64/python3.9/threading.py", line 917, in run
10:57:41     self._target(*self._args, **self._kwargs)
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 528, in _handle_tasks
10:57:41     for taskseq, set_length in iter(taskqueue.get, None):
10:57:41 
10:57:41 ~~~~~~~~~~~~~~~~~~~~~ Stack of Thread-26 (139989539898944) ~~~~~~~~~~~~~~~~~~~~~
10:57:41   File "/usr/lib64/python3.9/threading.py", line 937, in _bootstrap
10:57:41     self._bootstrap_inner()
10:57:41   File "/usr/lib64/python3.9/threading.py", line 980, in _bootstrap_inner
10:57:41     self.run()
10:57:41   File "/usr/lib64/python3.9/threading.py", line 917, in run
10:57:41     self._target(*self._args, **self._kwargs)
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 519, in _handle_workers
10:57:41     cls._wait_for_updates(current_sentinels, change_notifier)
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 499, in _wait_for_updates
10:57:41     wait(sentinels, timeout=timeout)
10:57:41   File "/usr/lib64/python3.9/multiprocessing/connection.py", line 935, in wait
10:57:41     ready = selector.select(timeout)
10:57:41   File "/usr/lib64/python3.9/selectors.py", line 416, in select
10:57:41     fd_event_list = self._selector.poll(timeout)
10:57:41 
10:57:41 ~~~~~~~~~~~~~~~~~~~~ Stack of MainThread (139990465660736) ~~~~~~~~~~~~~~~~~~~~~
10:57:41   File "/usr/lib64/python3.9/runpy.py", line 197, in _run_module_as_main
10:57:41     return _run_code(code, main_globals, None,
10:57:41   File "/usr/lib64/python3.9/runpy.py", line 87, in _run_code
10:57:41     exec(code, run_globals)
10:57:41   File "/usr/lib/python3.9/site-packages/pytest/__main__.py", line 5, in <module>
10:57:41     raise SystemExit(pytest.console_main())
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/config/__init__.py", line 185, in console_main
10:57:41     code = main()
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/config/__init__.py", line 162, in main
10:57:41     ret: Union[ExitCode, int] = config.hook.pytest_cmdline_main(
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286, in __call__
10:57:41     return self._hookexec(self, self.get_hookimpls(), kwargs)
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93, in _hookexec
10:57:41     return self._inner_hookexec(hook, methods, kwargs)
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84, in <lambda>
10:57:41     self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187, in _multicall
10:57:41     res = hook_impl.function(*args)
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 316, in pytest_cmdline_main
10:57:41     return wrap_session(config, _main)
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 269, in wrap_session
10:57:41     session.exitstatus = doit(config, session) or 0
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 323, in _main
10:57:41     config.hook.pytest_runtestloop(session=session)
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286, in __call__
10:57:41     return self._hookexec(self, self.get_hookimpls(), kwargs)
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93, in _hookexec
10:57:41     return self._inner_hookexec(hook, methods, kwargs)
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84, in <lambda>
10:57:41     self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187, in _multicall
10:57:41     res = hook_impl.function(*args)
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 348, in pytest_runtestloop
10:57:41     item.config.hook.pytest_runtest_protocol(item=item, nextitem=nextitem)
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286, in __call__
10:57:41     return self._hookexec(self, self.get_hookimpls(), kwargs)
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93, in _hookexec
10:57:41     return self._inner_hookexec(hook, methods, kwargs)
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84, in <lambda>
10:57:41     self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187, in _multicall
10:57:41     res = hook_impl.function(*args)
10:57:41   File "/builddir/build/BUILDROOT/python-pytest-rerunfailures-9.1.1-3.el9.noarch/usr/lib/python3.9/site-packages/pytest_rerunfailures.py", line 240, in pytest_runtest_protocol
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 126, in runtestprotocol
10:57:41     reports.append(call_and_report(item, "call", log))
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 215, in call_and_report
10:57:41     call = call_runtest_hook(item, when, **kwds)
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 254, in call_runtest_hook
10:57:41     return CallInfo.from_call(
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 311, in from_call
10:57:41     result: Optional[TResult] = func()
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 255, in <lambda>
10:57:41     lambda: ihook(item=item, **kwds), when=when, reraise=reraise
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286, in __call__
10:57:41     return self._hookexec(self, self.get_hookimpls(), kwargs)
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93, in _hookexec
10:57:41     return self._inner_hookexec(hook, methods, kwargs)
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84, in <lambda>
10:57:41     self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187, in _multicall
10:57:41     res = hook_impl.function(*args)
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 162, in pytest_runtest_call
10:57:41     item.runtest()
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 1641, in runtest
10:57:41     self.ihook.pytest_pyfunc_call(pyfuncitem=self)
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286, in __call__
10:57:41     return self._hookexec(self, self.get_hookimpls(), kwargs)
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93, in _hookexec
10:57:41     return self._inner_hookexec(hook, methods, kwargs)
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84, in <lambda>
10:57:41     self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
10:57:41   File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187, in _multicall
10:57:41     res = hook_impl.function(*args)
10:57:41   File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 183, in pytest_pyfunc_call
10:57:41     result = testfunction(**testargs)
10:57:41   File "/home/jenkins-agent/workspace/ci_linux-rhel/ws/src/ros2/ros2cli/ros2cli/test/test_flake8.py", line 22, in test_flake8
10:57:41     rc, errors = main_with_errors(argv=[])
10:57:41   File "/home/jenkins-agent/workspace/ci_linux-rhel/ws/install/ament_flake8/lib/python3.9/site-packages/ament_flake8/main.py", line 88, in main_with_errors
10:57:41     report = generate_flake8_report(
10:57:41   File "/home/jenkins-agent/workspace/ci_linux-rhel/ws/install/ament_flake8/lib/python3.9/site-packages/ament_flake8/main.py", line 281, in generate_flake8_report
10:57:41     report.report = style.check_files(paths)
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/api/legacy.py", line 109, in check_files
10:57:41     self._application.run_checks(paths)
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/main/application.py", line 271, in run_checks
10:57:41     self.file_checker_manager.run()
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 309, in run
10:57:41     self.run_parallel()
10:57:41   File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 275, in run_parallel
10:57:41     for ret in pool_map:
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 448, in <genexpr>
10:57:41     return (item for chunk in result for item in chunk)
10:57:41   File "/usr/lib64/python3.9/multiprocessing/pool.py", line 858, in next
10:57:41     self._cond.wait(timeout)
10:57:41   File "/usr/lib64/python3.9/threading.py", line 312, in wait
10:57:41     waiter.acquire()
10:57:41 
10:57:41 +++++++++++++++++++++++++++++++++++ Timeout ++++++++++++++++++++++++++++++++++++
``` 
</details>

@fujitatomoya
Copy link
Collaborator Author

retry CI:

  • Linux-rhel Build Status
  • Linux-rhel-debug Build Status

@fujitatomoya
Copy link
Collaborator Author

So after all, it says https://github.com/ros2/rclpy/pull/1363/files is the one that generated the regression. can anybody tell me why ❓❓❓

@fujitatomoya
Copy link
Collaborator Author

i will go ahead to close this. because this is NOT the cause of the flake8 segmentation fault, and we can keep tracking with ament/ament_lint#505.

@clalancette clalancette deleted the revert-1338-TransitionCallbackReturn branch November 22, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍🌾 ros2cli pytest timeout in RHEL nightlies
2 participants