Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for when sim time is active but unset #229

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Add test for when sim time is active but unset #229

merged 1 commit into from
Aug 21, 2018

Conversation

dhood
Copy link
Member

@dhood dhood commented Aug 21, 2018

Currently the time is uninitialised in rcl in that state Should be addressed by ros2/rcl#283

I added this test in the past and it would fail. CI should pass now:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dhood
Add failing test for when sim time is active but unset
32fb8e7 
Currently the time is uninitialised in rcl in that state
@dhood dhood added the in progress Actively being worked on (Kanban column) label Aug 21, 2018
@dhood dhood self-assigned this Aug 21, 2018
@dhood dhood merged commit 813599b into master Aug 21, 2018
@dhood dhood deleted the uninitialised_ros_clock branch August 21, 2018 20:22
@dhood dhood removed the in progress Actively being worked on (Kanban column) label Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees

@dhood dhood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhood @dirk-thomas