Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assert_liveliness use of node and publisher capsules #340

Merged
merged 1 commit into from
May 6, 2019
Merged

Fix assert_liveliness use of node and publisher capsules #340

merged 1 commit into from
May 6, 2019

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented May 6, 2019

I overlooked this when merging #313. The publisher and node pycapsules are managed by self.handle instead of using node_handle and publisher_handle.

There are no tests for these APIs at the moment.

@sloretz
Capsule available at self.handle
694b406 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added the in review Waiting for review (Kanban column) label May 6, 2019
@sloretz sloretz self-assigned this May 6, 2019
sloretz referenced this pull request May 6, 2019
@emersonknapp @sloretz
QoS - Expose the assert_liveliness API for Publishers and Nodes (#313)
4ba8c1b 
* Expose the assert_liveliness API for Publishers and Nodes

Signed-off-by: Emerson Knapp <eknapp@amazon.com>

* Use rclpy_publisher_t

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@sloretz
Copy link
Contributor Author

sloretz commented May 6, 2019

CI (testing just rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor Author

sloretz commented May 6, 2019

CI looks good. test_timer with 0.01 period failed, which is surprising, but is very unlikely to be caused by this PR.

@sloretz sloretz merged commit 48c5ba2 into master May 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the sloretz/fix_old_handle_refs branch May 6, 2019 22:08
@sloretz sloretz removed the in review Waiting for review (Kanban column) label May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

@emersonknapp emersonknapp Awaiting requested review from emersonknapp

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sloretz @wjwwood