Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise custom error when node name is not found #413

Merged
merged 5 commits into from
Sep 17, 2019
Merged

Raise custom error when node name is not found #413

merged 5 commits into from
Sep 17, 2019

Commits on Sep 16, 2019

  1. Raise custom exception when rclpy_get_*_names_and_types_by_node doesn… 

    …'t find a node name

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    2968a85 View commit details
    Browse the repository at this point in the history

  2. Delete commented line 

    Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    1453141 View commit details
    Browse the repository at this point in the history

  3. Move new exception to node.py 

    Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    666c421 View commit details
    Browse the repository at this point in the history

  4. Use CamelCase instead of snake_case in exception names 

    Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    0a4fe6f View commit details
    Browse the repository at this point in the history

  5. Delete old code 

    Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    bdcbe25 View commit details
    Browse the repository at this point in the history