Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __enter__ and __exit__ to JumpHandle #862

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Add __enter__ and __exit__ to JumpHandle #862

merged 1 commit into from
Dec 10, 2021

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Dec 10, 2021

Split from #858

This allows JumpHandle to be used with Python's with keyword, guaranteeing the time jump callback is unregestered even if an exception is thrown.

@sloretz
Add __enter__ and __exit__ to JumpHandle
83484c0 
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
@sloretz sloretz self-assigned this Dec 10, 2021
@sloretz
Copy link
Contributor Author

sloretz commented Dec 10, 2021

CI (build: --packages-up-to rclpy test: --packages-select rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit 3af0178 into master Dec 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the JumpHandle_enter_exit branch December 10, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sloretz @j-rivero