type trait rcpputils::is_pointer<T>` #19
Conversation
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
CI:
|
| #include "rcpputils/pointer_traits.hpp" | ||
|
|
||
| TEST(TestPointerTraits, is_pointer) { | ||
| auto ptr = new int(13); |
There was a problem hiding this comment.
Should delete this at the end of the test.
There was a problem hiding this comment.
Sorry noticed this after approving and green CI, and we don't run ASan/TSan jobs in CI so this won't get flagged in that either.
There was a problem hiding this comment.
No worries, you're absolutely right!
Addressed in 49c52d8
|
|
||
| TEST(TestPointerTraits, is_pointer) { | ||
| auto ptr = new int(13); | ||
| const auto * const cptrc = new int(13); |
There was a problem hiding this comment.
this one is also new allocated
There was a problem hiding this comment.
true, but this was passed into a shared pointer object and thus deallocated
To stay consistent, I've also addressed this in 49c52d8
There was a problem hiding this comment.
Oh, you're right! Thanks for making it more obvious though :)
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Karsten1987
force-pushed
the
pointer_type_traits
branch
from
260c3a4 to
49c52d8
Compare
|
new round of CI:
|
|
OSX failed with a network error, restarted to see if it was just a hiccup |
Moving the PR ros2/rclcpp#817 over to
rcpputils.I hopefully addressed previous feedback about adding documentation to it. Please let me know if the documentation is sufficient or if more details should be provided.
Signed-off-by: Karsten Knese karsten@openrobotics.org