Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more documentation and include doxyfile #46

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Feb 29, 2020

To help bring this package up to quality level 1, this PR includes additional doxygen comment blocks for public functionality. Also included is a doxyfile.

Signed-off-by: Stephen Brawner brawner@gmail.com

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner requested a review from a team as a code owner February 29, 2020 22:47
@brawner brawner mentioned this pull request Feb 29, 2020
Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM on passing tests

Copy link

@thomas-moulard thomas-moulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make sure the style is consistent across all comments? I just selected two places, but there are probably more. See the coding style: https://google.github.io/styleguide/cppguide.html#Comments

include/rcpputils/filesystem_helper.hpp Show resolved Hide resolved
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner
Copy link
Contributor Author

brawner commented Mar 5, 2020

This PR passes tests and has two approvals if someone would like to merge it (unless of course someone else has comments).

@emersonknapp emersonknapp merged commit 6bc8fa8 into ros2:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants