Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thread_safety_annotation filename to .hpp #6

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Fix thread_safety_annotation filename to .hpp #6

merged 1 commit into from
Mar 28, 2019

Conversation

emersonknapp
Copy link
Contributor

@emersonknapp emersonknapp commented Mar 28, 2019 •
edited
Loading

Signed-off-by: Emerson Knapp eknapp@amazon.com

@emersonknapp emersonknapp mentioned this pull request Mar 28, 2019
Merged
thomas-moulard
thomas-moulard requested changes Mar 28, 2019
View reviewed changes
Copy link

@thomas-moulard thomas-moulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test must be updated too.

@thomas-moulard
Copy link

@emersonknapp Can you attach a Gist to this PR so that I can run CI?

@emersonknapp
Copy link
Contributor Author

@thomas-moulard the test is updated - maybe you were looking at an outdated version?

https://gist.githubusercontent.com/emersonknapp/ada52a24239862ffb123a3538ef0e8be/raw/5f976a9ae8efe355770af59fc38a373d71b85252/hpp-name.repos

thomas-moulard
thomas-moulard reviewed Mar 28, 2019
View reviewed changes
Copy link

@thomas-moulard thomas-moulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm - indeed it is!

@thomas-moulard
Copy link

thomas-moulard commented Mar 28, 2019 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

thomas-moulard
thomas-moulard approved these changes Mar 28, 2019
View reviewed changes
Copy link

@thomas-moulard thomas-moulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CI is green.

@thomas-moulard
Copy link

@emersonknapp this is green - please add a DCO to this one and merge 🚢

Fix thread_safety_annotation filename to .hpp
3087c1e 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp merged commit 7d25362 into ros2:master Mar 28, 2019
@emersonknapp emersonknapp deleted the hpp-name branch March 28, 2019 06:58
@emersonknapp emersonknapp mentioned this pull request Apr 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

@thomas-moulard thomas-moulard thomas-moulard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emersonknapp @thomas-moulard @tfoote