Migrate launch tests to new launch_testing features & API #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
pbaughman
reviewed
Apr 9, 2019
| return_code = launch_test.run(launch_service) | ||
| assert return_code == 0, 'Launch failed with exit code %r' % (return_code,) | ||
| return launch_description, {'processes_to_test': processes_to_test} | ||
|
|
There was a problem hiding this comment.
I suspect the lack of 'active' tests here will cause an issue, but it might be a problem that needs to be fixed in launch_testing. I'm suspicious that in the absence of tests, the test thread can send the 'shutdown' signal to the LaunchService before it's finished launching the processes, which may cause the test runner to hang waiting for the LaunchService to terminate. For robustness, it might be worth waiting for the process_to_test to terminate.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
added
in review
29 tasks
ivanpauno
reviewed
Apr 26, 2019
| proc_output.assertWaitFor( | ||
| expected_output=launch_testing.tools.expected_output_from_file( | ||
| path=os.path.join(os.path.dirname(__file__), process_name) | ||
| ), process=process_name, timeout=10 |
There was a problem hiding this comment.
Maybe, it's clearer process and timeout in a new line.
There was a problem hiding this comment.
I could but it looks odd, right before the comma if you drop a line here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to ros2/launch#208.