Don't leak memory on realloc failing. #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reallocing a memory region, it is possible for the allocation to fail. If it does, and you are directly assigning to the "original" pointer, you'll lose the pointer and hence leak the memory. Store the result of the reallocation in a temporary, do error checking, and then only reassign char_array->buffer once we are confident it points to real memory. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
piraka9011
approved these changes
Apr 10, 2020
|
After looking further, this will solve the leaks in test_char_array.c, but not in test_logging_custom_env.cpp. That will need another fix (which I have ready). I still think we should proceed with this simple change, as it is a step forward, and then I'll open another PR with the other fixes. |
|
CI:
|
mjcarroll
approved these changes
Apr 10, 2020
Karsten1987
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reallocing a memory region, it is possible for the allocation
to fail. If it does, and you are directly assigning to the
"original" pointer, you'll lose the pointer and hence leak
the memory. Store the result of the reallocation in a temporary,
do error checking, and then only reassign char_array->buffer
once we are confident it points to real memory.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This should fix #231