Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rcutils_fault_injection_set_count to use int64_t #283

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Aug 26, 2020

Discovered this warning during a ci_windows build for ros2/rmw_dds_common#27. The integer type for set count doesn't match the one for get count.

Example warning:
Build Status

Signed-off-by: Stephen Brawner brawner@gmail.com

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner
Copy link
Contributor Author

brawner commented Aug 26, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@brawner brawner requested a review from hidmic August 26, 2020 21:24
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@brawner brawner merged commit a287e74 into master Aug 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/fault-injection-set-count-int64_t branch August 26, 2020 22:16
ahcorde pushed a commit that referenced this pull request Oct 2, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
ahcorde pushed a commit that referenced this pull request Oct 6, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants