Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the temporary variable in RCUTILS_LOGGING_AUTOINIT #290

Merged
merged 3 commits into from
Oct 5, 2020
Merged

Remove the temporary variable in RCUTILS_LOGGING_AUTOINIT #290

merged 3 commits into from
Oct 5, 2020

Commits on Oct 1, 2020

  1. Update logging.h 

    Fix issue ros2#285:
Remove the temporary variable in a macro, because the name of the variable may shadow a variable of the macro user.
As suggested by @clalancette, also wrapped it into a do-while wrapping.

Signed-off-by: Felix Endres <felix-endres-github@256bit.org>
    @felixendres @clalancette
    felixendres authored and clalancette committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    21da076 View commit details
    Browse the repository at this point in the history

  2. Remove trailing semicolon. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    d8d9599 View commit details
    Browse the repository at this point in the history

  3. Add semicolon to end of RCUTILS_LOGGING_AUTOINIT. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    fbb804f View commit details
    Browse the repository at this point in the history