Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare dependency on libatomic #338

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Declare dependency on libatomic #338

merged 1 commit into from
Apr 9, 2021

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Apr 8, 2021

To prefer the system atomics implementation over the fallback implementation in rcutils, declare a dependency on it to ensure it's available on systems that have it.

Current RPM builds for RHEL are using the fallback implementation due to this missing dependency.

Backing rosdep rules: https://github.com/ros/rosdistro/blob/96e2f40ae3400f6d2dc22cce9333f42fa6e4e4be/rosdep/base.yaml#L1856-L1861

To prefer the system atomics implementation over the fallback
implementation in rcutils, declare a dependency on it to ensure it's
available on systems that have it.

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay added the bug Something isn't working label Apr 8, 2021
@cottsay cottsay self-assigned this Apr 8, 2021
@cottsay
Copy link
Member Author

cottsay commented Apr 8, 2021

Since this is just a package.xml change, running CI would provide no value.

@clalancette
Copy link
Contributor

Since this is just a package.xml change, running CI would provide no value.

What might provide value, though is to edit the CI scripts to install libatomic1 on Ubuntu, then run CI. That way we would at least know that this change doesn't substantially change anything on Ubuntu (and we should probably merge that change as well, since that is what build.ros2.org is going to be doing when it builds the binary package).

@cottsay
Copy link
Member Author

cottsay commented Apr 8, 2021

This is a required dependency for iceoryx_utils, which built successfully in this nightly, which came back green:

Build Status

So it's already present for CI. It was probably already installed as a recursive dependency prior to the introduction of Iceoryx.

@cottsay cottsay merged commit 0c9a931 into master Apr 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the cottsay/libatomic_dep branch April 9, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants