time_unix: namespace zephyr headers #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @pablogs9 |
|
@clalancette @ahcorde PTAL |
pablogs9
reviewed
Sep 15, 2022
uLipe
force-pushed
the
feature/zephyr_namespace
branch
from
7bf8043
to
9cbf466
Compare
|
@pablogs9 @clalancette @ahcorde PTAL again. |
uLipe
force-pushed
the
feature/zephyr_namespace
branch
2 times, most recently
from
e2ff899
to
0df2ddc
Compare
when kernel is above version 3. Signed-off-by: Felipe Neves <felipe.neves@linaro.org>
uLipe
force-pushed
the
feature/zephyr_namespace
branch
from
0df2ddc
to
be19c37
Compare
|
@fujitatomoya PTAL again also. |
|
The new way to check version LGTM |
clalancette
approved these changes
Sep 30, 2022
|
CI:
|
|
@clalancette , I agree on you, the solution is not the most elegant but needed to make this supported across Zephyr versions 2.7 and 3.1 the header namespacing in Zephyr is introducing the same problem in others external modules . |
fujitatomoya
approved these changes
Sep 30, 2022
|
good to go with green CI. |
|
Basically by definition, this change can't have made the one test on Windows fail. That one is flaky every once in a while anyway. Going ahead and merging this. |
|
PTAL here: micro-ROS/micro_ros_zephyr_module#85 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After version 3, the Zephyr RTOS requires to namespace all its headers with zephyr before including any other header file that belongs to it, this PR checks the version o major number of the kernel and when above 3, namespace the Zephyr specific posix timer implementation.