Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused references to mimick/mocking in tests #450

Conversation

christophebedard
Copy link
Member

A bunch of mimick-based tests were added in #272. Some of those tests were removed in #275, but some now-unnecessary references/includes weren't removed, so clean them up.

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
@ahcorde
Copy link
Contributor

ahcorde commented Feb 5, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@christophebedard
Copy link
Member Author

The ci_linux job is failing due to the agent running out of space: RuntimeError: [Errno 28] No space left on device [log/build_2024-02-05_12-31-21/events.log]. Re-triggering:

  • Linux Build Status

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@ahcorde ahcorde merged commit 3cc0d0c into ros2:rolling Feb 5, 2024
3 checks passed
@christophebedard christophebedard deleted the christophebedard/clean-up-tests-mimick branch February 5, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants