Only return statistics if they have been calculated. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to call rttest_get_statistics() *before* any statistics have been collected, accumulated, or calculated. In that case, return a -1 from rttest_get_statistics() indicate to the caller that the data is not yet available. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI is in ros2/demos#385 (comment) |
The regex that we use over in demos to test some of this stuff out only handles floating-point numbers, not scientific notation. The mean latency, in particular, can grow into a value large enough that it will get put into scientific notation by default. This fixes this output to be fixed so the regex will always be able to find it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
dirk-thomas
approved these changes
Aug 22, 2019
|
I'm going to merge this one, since it improves things. We'll need the changes from ros2/demos#385 to really fix these tests, but we are still iterating there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to call rttest_get_statistics() before any
statistics have been collected, accumulated, or calculated.
In that case, return a -1 from rttest_get_statistics() indicate
to the caller that the data is not yet available.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org