Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rmw_get_gid_for_client method #327

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Add rmw_get_gid_for_client method #327

merged 2 commits into from
Sep 23, 2022

Conversation

ihasdapie
Copy link
Member

@ihasdapie ihasdapie commented Aug 15, 2022 •
edited
Loading

Add rmw_get_gid_for_client method. This is needed for the service introspection feature (ros2/ros2#1285) to populate client uuid fields.

Link to impl PRs:

Signed-off-by: Brian Chen brian.chen@openrobotics.org

@ihasdapie
add rmw_get_gid_for_client
a060170 
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
This was referenced Aug 15, 2022
Closed
Merged
Merged
Merged
Closed
jacobperron
jacobperron reviewed Aug 15, 2022
View reviewed changes
rmw/include/rmw/rmw.h Outdated Show resolved Hide resolved
ivanpauno
ivanpauno reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Jacob's comments addressed

@jacobperron
Add documentation and remove extra empty line
a404f19 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ivanpauno
ivanpauno approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

do we need rmw_get_gid_for_service?
should we also add it?

No need to solve that here, just wondering if we should add that.

@ivanpauno ivanpauno added the enhancement New feature or request label Sep 19, 2022
@jacobperron
Copy link
Member

I don't think we need a rmw_get_gid_for_service for the service introspection feature, but I don't think it hurts to add such an API for symmetry. I can create a ticket for this.

@jacobperron
Copy link
Member

jacobperron commented Sep 19, 2022 •
edited
Loading

Full CI for all connected PRs:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Connected PRs:

@jacobperron jacobperron mentioned this pull request Sep 19, 2022
Closed
@jacobperron jacobperron merged commit 67b0f0a into rolling Sep 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the brianc/rmw_get_gid_for_client branch September 23, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron left review comments

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

@jacobperron jacobperron

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ihasdapie @jacobperron @ivanpauno