Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message Count API Creation #364

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

CursedRock17
Copy link

This PR is meant in preparation for issue #1109 in the rcl repository by creating a rmw API for counting messages a Subscription is ready to receive.

Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
@fujitatomoya
Copy link
Collaborator

@CursedRock17 thanks for creating PR.

IMO, this requires RMW change, i would suggest that before moving forward, probably it would be nice to have discussion on basic design describes how we could implement this underlying rmw implementation, including client interfaces? maybe REP required, i am not sure... @clalancette @wjwwood WDYT?

@clalancette
Copy link
Contributor

IMO, this requires RMW change, i would suggest that before moving forward, probably it would be nice to have discussion on basic design describes how we could implement this underlying rmw implementation, including client interfaces? maybe REP required, i am not sure... @clalancette @wjwwood WDYT?

Yeah, agreed. I'd like to see draft PRs, or at least documentation, on how we would implement this for rmw_fastrtps, rmw_cyclonedds, rmw_connextdds, and rmw_zenoh.

@clalancette clalancette added the more-information-needed Further information is required label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants