Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Implement the rmw_get_publishers_info_by_topic and rmw_get_subscriptions_info_by_topic methods #380

Closed
jaisontj opened this issue Dec 11, 2019 · 5 comments
Assignees

Comments

@jaisontj
Copy link
Contributor

As a follow up to this PR which returns RMW_RET_UNSUPPORTED for the rmw_get_publishers_info_by_topic and rmw_get_subscriptions_info_by_topic; ensure that these methods are implemented before the ROS2 F release.

These methods are implemented in rmw_fastrtps in this PR which can be used as a reference.

@ivanpauno
Copy link
Member

Assigning myself, same comment as ros2/rmw_opensplice#299 (comment).

@wjwwood
Copy link
Member

wjwwood commented Jan 21, 2020

When this is done, the tests need to be fixed in rclpy to actually test things:

https://github.com/ros2/rclpy/pull/454/files#diff-960e40f792ccd92281ee56dfb65726bcR197

@mm318
Copy link
Member

mm318 commented Feb 21, 2020

The pull request for resolving this issue has been opened at #391.

@mm318
Copy link
Member

mm318 commented Feb 21, 2020

When this is done, the tests need to be fixed in rclpy to actually test things:

https://github.com/ros2/rclpy/pull/454/files#diff-960e40f792ccd92281ee56dfb65726bcR197

This change is in pull request ros2/rclpy#511.

@clalancette
Copy link
Contributor

Closing, since with Foxy now being End-of-Life, this repository is no longer used.

@clalancette clalancette closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants