Logging manipulation API from rmw_connext #266
Conversation
- Currently no support from DDS to enable this. - Modify Cmake to enable compilation of the file. Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
Signed-off-by: Sriram Raghunathan <sriram.max@gmail.com>
rmw_connext_cpp/src/rmw_logging.cpp
Outdated
| rmw_ret_t | ||
| rmw_set_log_severity(rmw_log_severity_t severity) | ||
| { | ||
| return RMW_RET_OK; |
There was a problem hiding this comment.
As long as this is not implemented it shouldn't return "ok".
There was a problem hiding this comment.
Since, this is not implemented yet. An error returned might disturb the normal execution, so for time being till we find ways to implement the same inside DDS thought a "OK" (by-pass) would be better.
There was a problem hiding this comment.
Can you look into implementing this function or do you propose to merge this as-is?
There was a problem hiding this comment.
@dirk-thomas Please merge as-is. I'll look into implementing this patch at later point. Thank you.
|
@dirk-thomas @dhood Could you please review this patch? This is connected to another approved patch by Dirk |
I am still waiting for an answer on my previous question. |
…statement, this is temporary patch
This follows a series of changes on all the DDS specific implementation to let user programs manipulate logging levels.
Connect to ros2/rmw#124