Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

deduplicate code #312

Merged
merged 1 commit into from
Jan 10, 2019
Merged

deduplicate code #312

merged 1 commit into from
Jan 10, 2019

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Nov 30, 2018

Follow up of #308 (comment)

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood added enhancement New feature or request in review Waiting for review (Kanban column) labels Nov 30, 2018
@wjwwood wjwwood self-assigned this Nov 30, 2018
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm pending green CI

@wjwwood
Copy link
Member Author

wjwwood commented Dec 20, 2018

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas
Copy link
Member

@ros-pull-request-builder retest this please

@dirk-thomas dirk-thomas merged commit e71347b into master Jan 10, 2019
@dirk-thomas dirk-thomas deleted the refactor_init_followup branch January 10, 2019 21:16
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jan 10, 2019
dabonnie pushed a commit to aws-ros-dev/rmw_connext that referenced this pull request Apr 3, 2019
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants