Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Use rpputils::find_and_replace instead of std::regex_replace #359

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Use rpputils::find_and_replace instead of std::regex_replace #359

merged 1 commit into from
Jun 28, 2019

Conversation

jacobperron
Copy link
Member

The rcpputils implementation is more performant.

Related to ros2/rmw_fastrtps#277
Requires ros2/rcpputils#13

@jacobperron
Use rpputils::find_and_replace instead of std::regex_replace
070d54d 
The rcpputils implementation is more performant.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
sloretz
sloretz reviewed Jun 10, 2019
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need ament_export_dependencies(rcpputils)?

@jacobperron
Copy link
Member Author

Need ament_export_dependencies(rcpputils)?

Done in 216445d

@sloretz
Copy link
Contributor

sloretz commented Jun 10, 2019 •
edited
Loading

Need ament_export_dependencies(rcpputils)?

Done in 216445d

Oops, I missed that rcpputils::find_and_replace is header only (edit: and not included in any includes installed by this package). Exporting the dependency wasn't necessary.

@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron
Copy link
Member Author

Oops, I missed that rcpputils::find_and_replace is header only (edit: and not included in any includes installed by this package). Exporting the dependency wasn't necessary

Reverted.

@jacobperron
Copy link
Member Author

jacobperron commented Jun 12, 2019 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron
Copy link
Member Author

After running CI against master (ros2/rmw_opensplice#264 (comment)), it looks like the test failures already exist and are related to builds with OpenSplice.

@jacobperron jacobperron merged commit 980667f into master Jun 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/replace_regex branch June 28, 2019 17:16
@jacobperron jacobperron mentioned this pull request Jun 28, 2019
Closed
jacobperron added a commit that referenced this pull request Jul 26, 2019
@jacobperron
Use rpputils::find_and_replace instead of std::regex_replace (#359)
b1118b6 
The rcpputils implementation is more performant.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request Jul 26, 2019
Merged
jacobperron added a commit that referenced this pull request Jul 29, 2019
@jacobperron
Use rpputils::find_and_replace instead of std::regex_replace (#359)
45868d6 
The rcpputils implementation is more performant.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@dirk-thomas
Copy link
Member

The PR job for this change failed since the dependency hasn't been released yet. As a consequence the dev job is also failing now.

This was referenced Jul 29, 2019
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sloretz sloretz sloretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobperron @sloretz @dirk-thomas