Event listeners updated #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
* Use the new discovery params Signed-off-by: Michael X. Grey <grey@openrobotics.org> * Update to latest rmw API Signed-off-by: Michael X. Grey <grey@openrobotics.org> * Fix typo Signed-off-by: Michael X. Grey <grey@openrobotics.org> * Fix memory management Signed-off-by: Michael X. Grey <grey@openrobotics.org> * Make sure NDDS_DISCOVERY_PEERS is not empty when ROS_AUTOMATIC_DISCOVERY_RANGE is LOCALHOST Signed-off-by: Andrea Sorbini <asorbini@rti.com> * fix up finalize logic Signed-off-by: William Woodall <william@osrfoundation.org> * typo Signed-off-by: William Woodall <william@osrfoundation.org> * check the return code of ensure_length() Signed-off-by: William Woodall <william@osrfoundation.org> * fixup use of memcpy when copying a string Signed-off-by: William Woodall <william@osrfoundation.org> * improve formatting of domain_tag string Signed-off-by: William Woodall <william@osrfoundation.org> * use c++17 [[fallthrough]] attribute Signed-off-by: William Woodall <william@osrfoundation.org> * change style of switch statement Signed-off-by: William Woodall <william@osrfoundation.org> * undo change to request c++17 vs 14 since we're not using fallthrough Signed-off-by: William Woodall <william@osrfoundation.org> * Handle all discovery options in rmw_context.cpp Signed-off-by: Andrea Sorbini <asorbini@rti.com> * Reset multicast_receive_addresses instead of setting NDDS_DISCOVERY_PEERS Signed-off-by: Andrea Sorbini <asorbini@rti.com> * error when range is NOT_SET Signed-off-by: William Woodall <william@osrfoundation.org> * fixup review comments Signed-off-by: William Woodall <william@osrfoundation.org> * fix a zero initialization issue Signed-off-by: William Woodall <william@osrfoundation.org> * remove redundant break statement Signed-off-by: William Woodall <william@osrfoundation.org> * Init discovery_options when initializing node options Signed-off-by: Shane Loretz <sloretz@google.com> * Set maximum participant ID to 32 on localhost Signed-off-by: Shane Loretz <sloretz@google.com> * Skipping adding peers when automatic_discovery_range is SYSTEM_DEFAULT Signed-off-by: Shane Loretz <sloretz@google.com> * Try solving los of precision warning on Windows Signed-off-by: Shane Loretz <sloretz@google.com> * Fix windows warning Signed-off-by: Shane Loretz <sloretz@google.com> --------- Signed-off-by: Michael X. Grey <grey@openrobotics.org> Signed-off-by: William Woodall <william@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@google.com> Co-authored-by: Shane Loretz <sloretz@google.com> Co-authored-by: Andrea Sorbini <asorbini@rti.com> Co-authored-by: William Woodall <william@osrfoundation.org>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
This reverts commit 882c7f1.
* Refactor serialization support to use allocators and refs Signed-off-by: methylDragon <methylDragon@gmail.com> * Use rmw_serialization_support_init Signed-off-by: methylDragon <methylDragon@gmail.com> --------- Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
Signed-off-by: Christopher Wecht <cwecht@mailbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.