Apply #43 to branch galactic
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improved conversion of time values between ROS and DDS formats * Account for no lifespan when converting reader qos * Adjust guard for LifespanQosPolicy Signed-off-by: Andrea Sorbini <asorbini@rti.com>
hidmic
approved these changes
Apr 29, 2021
|
clalancette
approved these changes
May 3, 2021
|
@clalancette @hidmic I haven't merged this PR yet because I'm not sure how the Please let me know if you'd want me to merge it myself instead. |
|
This has two approvals, so I'm going to go ahead and merge it for Galactic. Thanks for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the changes introduced by #43 to branch
galactic.The changes are required to resolve ros2/rosbag2#756, and they should be included in the Galactic release.