Ensure compliant node construction/destruction API. #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidmic
force-pushed
the
hidmic/ensure-compliant-node-construction-destruction
branch
from
854fc84 to
2a4a8d2
Compare
|
Conflicts resolved. Also adjusted changes based on discussions in ros2/rmw#249 and connected PRs. @eboasson PTAL! |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
hidmic/ensure-compliant-node-construction-destruction
branch
from
2a4a8d2 to
e2e4632
Compare
|
One last rebase, I made a mistake in the previous one. |
|
Running CI up to
|
clalancette
reviewed
Jul 14, 2020
rmw_cyclonedds_cpp/src/rmw_node.cpp
Outdated
| rmw_free(const_cast<char *>(node->namespace_)); | ||
| node->context->impl->fini(); | ||
| rmw_node_free(node); | ||
| assert(node->context != nullptr); |
There was a problem hiding this comment.
As with the other PRs around this, I'll suggest that we elide this check completely. See the conversation at ros2/rmw_fastrtps#408 (comment) for more details on to why.
There was a problem hiding this comment.
Uh, I thought I had removed them all. There, see 49992cd
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
clalancette
approved these changes
Jul 14, 2020
eboasson
approved these changes
Jul 14, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
delete-merged-branch
bot
deleted the
hidmic/ensure-compliant-node-construction-destruction
branch
ahcorde
pushed a commit
that referenced
this pull request
Oct 8, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 15, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to ros2/rmw#249.