Pass the CRL down to CycloneDDS if it exists. #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the rmw_dds_common layer tells us that the CRL exists, set the appropriate property so CycloneDDS will honor it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI for this is in ros2/rmw_dds_common#52 (comment) . That was green, and this is approved, so I'm going to go ahead and merge this. |
clalancette
added a commit
to eboasson/rmw_cyclonedds
that referenced
this pull request
May 18, 2022
If the rmw_dds_common layer tells us that the CRL exists, set the appropriate property so CycloneDDS will honor it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the rmw_dds_common layer tells us that the CRL exists,
set the appropriate property so CycloneDDS will honor it.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Note that this can be merged at any time, but will have no effect until ros2/rmw_dds_common#52 is merged.