Do not compile assert death tests in Release builds. (#393)

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ros2 · May 28, 2020 · 08a51c2 · 08a51c2
1 parent 56172ef
commit 08a51c2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/rmw_fastrtps_shared_cpp/test/test_guid_utils.cpp b/rmw_fastrtps_shared_cpp/test/test_guid_utils.cpp
@@ -26,12 +26,14 @@ static constexpr size_t byte_array_size =
   eprosima::fastrtps::rtps::EntityId_t::size;
 
 TEST(GUIDUtilsTest, bad_arguments) {
+#ifndef NDEBUG
   eprosima::fastrtps::rtps::GUID_t guid;
   uint8_t byte_array[byte_array_size] = {0};
   uint8_t * null_byte_array = nullptr;
   EXPECT_DEATH(copy_from_byte_array_to_fastrtps_guid(byte_array, nullptr), "");
   EXPECT_DEATH(copy_from_byte_array_to_fastrtps_guid(null_byte_array, &guid), "");
   EXPECT_DEATH(copy_from_fastrtps_guid_to_byte_array(guid, null_byte_array), "");
+#endif
 }
 
 TEST(GUIDUtilsTest, byte_array_to_guid_and_back) {

diff --git a/rmw_fastrtps_shared_cpp/test/test_names.cpp b/rmw_fastrtps_shared_cpp/test/test_names.cpp
@@ -67,9 +67,11 @@ TEST(NamespaceTest, name_mangling) {
   rmw_qos_profile_t qos_profile = rmw_qos_profile_unknown;
   qos_profile.avoid_ros_namespace_conventions = false;
 
+#ifndef NDEBUG
   EXPECT_DEATH(_create_topic_name(nullptr, "", "", ""), "");
 
   EXPECT_DEATH(_create_topic_name(&qos_profile, "", nullptr, ""), "");
+#endif
 
   EXPECT_STREQ(
     "some_ros_prefix/test__suffix", _create_topic_name(