Create README.md #340
Merged
Create README.md #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
|
Please start each sentence on a new line (following the styleguide). |
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
|
Thanks @dirk-thomas! Did not know about that |
dirk-thomas
reviewed
Dec 5, 2019
README.md
Outdated
|
|
||
| `rmw_fastrtps` actually provides not one but two different ROS2 middleware implementations, both of them using Fast-RTPS as middleware layer: `rmw_fastrtps_cpp` and `rmw_fastrtps_dynamic_cpp` (note that directory `rmw_fastrtps_shared_cpp` just contains the code that the two implementations share, and does not constitute a layer on its own). | ||
|
|
||
| The main difference between the two is that `rmw_fastrtps_dynamic_cpp` uses ROS2 Introspection at run time to decide on the serialization/deserialization mechanism, meaning that the application can be agnostic of the message types. |
There was a problem hiding this comment.
Instead of:
... ROS2 Introspection ...
I would suggest:
... introspection typesupport ...
The "ROS2" seems unnecessary here and the typesupport is the important missing term.
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
|
Thanks @dirk-thomas! I have applied the changes you suggested. |
|
Thanks for this contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: EduPonz eduardoponz@eprosima.com