Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checked client implementation and return RMW_RET_INCORRECT_RMW_IMPLEMENTATION in rmw_service_server_is_available #451

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Checked client implementation and return RMW_RET_INCORRECT_RMW_IMPLEMENTATION in rmw_service_server_is_available #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion rmw_fastrtps_shared_cpp/src/rmw_service_server_is_available.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,18 @@ __rmw_service_server_is_available(
RMW_CHECK_TYPE_IDENTIFIERS_MATCH(
node handle,
node->implementation_identifier, identifier,
return RMW_RET_ERROR);
return RMW_RET_INCORRECT_RMW_IMPLEMENTATION);

if (!client) {
RMW_SET_ERROR_MSG("client handle is null");
return RMW_RET_ERROR;
}

RMW_CHECK_TYPE_IDENTIFIERS_MATCH(
client handle,
client->implementation_identifier, identifier,
return RMW_RET_INCORRECT_RMW_IMPLEMENTATION);

if (!is_available) {
RMW_SET_ERROR_MSG("is_available is null");
return RMW_RET_ERROR;
Expand Down