Extend XML examples #504
Merged
Extend XML examples #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
hidmic
approved these changes
Jan 19, 2021
README.md
Outdated
| @@ -87,15 +87,15 @@ For doing so, `rmw_fastrtps` locates profiles in the XML based on topic names ab | |||
|
|
|||
| ##### Creating publishers/subscriptions with different profiles | |||
|
|
|||
| To configure a publisher/subscription, define a `<publisher>`/`<subscriber>` profile with attribute `profile_name=topic_name`. | |||
| To configure a publisher/subscription, define a `<publisher>`/`<subscriber>` profile with attribute `profile_name=topic_name`, where topic name is the name of the topic before mangling, i.e. the topic name used to create the publisher/subscription on `rclcpp`/`rclpy`. | |||
There was a problem hiding this comment.
@EduPonz consider not mentioning client libraries directly to stay general (as examples at most)
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends XML examples to include different profile types selected by name.
Signed-off-by: EduPonz eduardoponz@eprosima.com