Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SubscriptionOptions::ignore_local_publications #537

Closed
wants to merge 10 commits into from

Conversation

jamoralp
Copy link
Contributor

Signed-off-by: Jose Antonio Moral joseantoniomoralparras@gmail.com

christophebedard and others added 5 commits May 4, 2021 10:25
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
)

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Added is_plain_ attribute to base TypeSupport.
* Added new methods to base TypeSupport.
* Implementation of rmw_borrow_loaned_message.
* Implementation of rmw_return_loaned_message_from_publisher.
* Enable loan messages on publishers of plain types.
* Implementation for taking loaned messages.
* Enable loan messages on subscriptions of plain types.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor

hidmic commented May 31, 2021

@jamoralp let's get this patch reviewed and merged into Rolling (#536) first. We can backport it with ROS Boss approvial later on.

Barry-Xu-2018 and others added 3 commits June 2, 2021 13:42
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@clalancette clalancette added the more-information-needed Further information is required label Jun 17, 2021
Signed-off-by: Jose Antonio Moral <joseantoniomoralparras@gmail.com>
Signed-off-by: Jose Antonio Moral <joseantoniomoralparras@gmail.com>
@MiguelCompany MiguelCompany deleted the feature/ignore_local_pub branch June 22, 2021 10:04
@MiguelCompany
Copy link
Collaborator

@hidmic Please close this in favor of #543. @jamoralp left eProsima and I don't know if he could close it or not.

@hidmic hidmic closed this Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants