Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeated matched event notification #682

Conversation

Barry-Xu-2018
Copy link
Contributor

Address #681

Signed-off-by: Barry Xu <barry.xu@sony.com>
@Barry-Xu-2018
Copy link
Contributor Author

Although this correction is targeted towards matched events, I guess other events may also have the same issue.

@fujitatomoya
Copy link
Collaborator

@MiguelCompany we would like you to review this PR, thanks in advance.

@fujitatomoya
Copy link
Collaborator

Just quick heads-up, https://docs.ros.org/en/rolling/Releases/Release-Iron-Irwini.html#release-timeline this must be addressed in this week.

@MiguelCompany
Copy link
Collaborator

@Barry-Xu-2018 @fujitatomoya I have taken a deep look into this.

Statuses publication_matched and subscription_matched should be handled specially on the RMW.
In particular, they should always be enabled on the listener mask, since we need track_unique_xxx to be called.

For other statuses, the listener is not called unless an event callback is set for that status.

I have created #683 with what I consider a better approach to fix the repeated notification.

@fujitatomoya
Copy link
Collaborator

@MiguelCompany @Barry-Xu-2018

i left a couple of comments, #683. I was not clear that this can address the repeated issue precisely.

@Barry-Xu-2018
Copy link
Contributor Author

@MiguelCompany thanks for your explanation. I understand.
I close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants