Support topic instances #753
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
reviewed
Apr 5, 2024
| * Max samples per instance is set to history depth if KEEP_LAST | ||
| * else UNLIMITED. | ||
| * | ||
| * \param[in] hitory_qos History entitiy QoS. |
There was a problem hiding this comment.
Suggested change
| * \param[in] hitory_qos History entitiy QoS. | |
| * \param[in] history_qos History entitiy QoS. |
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…ption Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…keys adoption Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Mario-DL
force-pushed
the
feature/rolling/keys
branch
from
9b3b8a9 to
32b2145
Compare
fujitatomoya
reviewed
Nov 5, 2024
rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/utils.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary code to support topic instances in
rmw_fastrtps_cppandrmw_fastrtps_dynamic_cpp@keyannotation rosidl#796@keyannotation rosidl_typesupport_fastrtps#116