This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
API to manipulate log setting macros #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2017 14:39
- Currently no support from DDS to enable this. - Modify Cmake to enable compilation of the file. Signed-off-by: Sriram Raghunathan <sriram.max@gmail.com>
Signed-off-by: Sriram Raghunathan <sriram.max@gmail..com>
dirk-thomas
reviewed
Oct 30, 2017
| rmw_ret_t | ||
| rmw_set_log_severity(rmw_log_severity_t severity) | ||
| { | ||
| return RMW_RET_OK; |
There was a problem hiding this comment.
As long as this is not implemented it shouldn't return "ok".
There was a problem hiding this comment.
Can you look into implementing this function or do propose to merge this as-is?
There was a problem hiding this comment.
@dirk-thomas Please merge as-is. I'll try to push in these changes after working on couple more patches.
|
@dirk-thomas @dhood Could you please review this patch? This is connected to another approved patch by Dirk |
I am still waiting for an answer on my previous question. |
added 2 commits
January 4, 2018 12:26
…statement, this is temporary patch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable manipulating logging macros from rmw_opensplice.
Connect to ros2/rmw#124