Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QoS logging during pub/sub creation #32

Merged
merged 24 commits into from
Sep 11, 2020
Merged

QoS logging during pub/sub creation #32

merged 24 commits into from
Sep 11, 2020

Conversation

codebot
Copy link
Member

@codebot codebot commented Sep 10, 2020

Adds DEBUG log messages that print the requested QoS for publisher and subscribers.

gbiggs
gbiggs requested changes Sep 10, 2020
View reviewed changes
@codebot
Copy link
Member Author

codebot commented Sep 10, 2020

Thanks for all of the style fixes. I believe that it is now passing the style checker successfully.

For people of the future, here is how you can run the style checker locally:

colcon test --packages-select rmw_zenoh_cpp && colcon test-result --verbose | less

@codebot codebot mentioned this pull request Sep 10, 2020
Closed
@methylDragon
Copy link
Contributor

Thanks for all of the style fixes. I believe that it is now passing the style checker successfully.

For people of the future, here is how you can run the style checker locally:

colcon test --packages-select rmw_zenoh_cpp && colcon test-result --verbose | less

Should we add this to the README? 👀

@gbiggs
Copy link
Member

gbiggs commented Sep 11, 2020

It's standard colcon/ament, so I don't think it's really necessary.

codebot and others added 24 commits September 11, 2020 10:17
@codebot @gbiggs
add debug log entries for qos creation of pubs/subs
1a543f3 
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
@codebot @gbiggs
add helper files
cdc9b4e 
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.cpp
0bdebbf 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.cpp
c2c2172 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.cpp
0ed3acd 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.cpp
879935b 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.cpp
d050376 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.cpp
7821d1c 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/rmw_publisher.cpp
3c6f0f5 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/rmw_subscriber.cpp
7224067 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/rmw_subscriber.cpp
8c34368 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.cpp
265a4fc 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.cpp
df1ea93 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.cpp
e7392d8 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.hpp
40355b7 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.hpp
d858925 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.cpp
2a9b783 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.cpp
5da2888 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.cpp
1645bbd 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.cpp
647e758 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/impl/debug_helpers.cpp
44741a5 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
Update rmw_zenoh_cpp/src/rmw_publisher.cpp
3957d35 
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
@codebot @gbiggs
remove unnecessary blank lines
98d6e0f 
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
@codebot @gbiggs
add copyright block and another style fix
c47bd69 
Signed-off-by: Morgan Quigley <morgan@osrfoundation.org>
@gbiggs gbiggs force-pushed the add_qos_debug_logging branch from 663e8ff to c47bd69 Compare September 11, 2020 01:20
@codebot codebot merged commit 79c3e72 into main Sep 11, 2020
@codebot codebot deleted the add_qos_debug_logging branch September 11, 2020 04:20
clalancette added a commit that referenced this pull request Nov 9, 2023
@Yadunund @clalancette
Add ros_domain_id as prefix to key expressions (#32)
1555f7e 
* Prefix keyexprs with the ros_domain_id

Signed-off-by: Yadunund <yadunund@openrobotics.org>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Yadunund added a commit that referenced this pull request Jan 12, 2024
@Yadunund @clalancette
Add ros_domain_id as prefix to key expressions (#32)
0c5f02c 
* Prefix keyexprs with the ros_domain_id

Signed-off-by: Yadunund <yadunund@openrobotics.org>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbiggs gbiggs gbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebot @methylDragon @gbiggs