Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake 3.10 compatibility: pass absolute path to file(GENERATE) function #100

Merged
merged 1 commit into from
Dec 3, 2017

Conversation

mikaelarguedas
Copy link
Member

This is needed to support cmake 3.10. We could define the policy based on the version of CMake but I preferred updating the codebase to have something compliant with all cmake versions without relying on undefined behavior.

More details at https://cmake.org/cmake/help/git-stage/policy/CMP0070.html

Example of CMake warning without this patch:

Policy CMP0070 is not set: Define file(GENERATE) behavior for relative
paths.  Run "cmake --help-policy CMP0070" for policy details.  Use the
cmake_policy command to set the policy and suppress this warning.

file(GENERATE) given relative OUTPUT path:

  test/test_services__rmw_connext_cpp_RelWithDebInfo.py

This is not defined behavior unless CMP0070 is set to NEW.  For
compatibility with older versions of CMake, the previous undefined behavior
will be used.

connects to ros2/rcl#195

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Dec 3, 2017
@mikaelarguedas mikaelarguedas merged commit 785997b into master Dec 3, 2017
@mikaelarguedas mikaelarguedas deleted the absolute_path_generate branch December 3, 2017 02:56
@mikaelarguedas mikaelarguedas removed the in progress Actively being worked on (Kanban column) label Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants