Allow external use of ros1_bridge factories #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Jan 23, 2019
paulbovbel
force-pushed
the
export-factories
branch
2 times, most recently
from
16a109c to
3873b76
Compare
|
|
|
Please address the linter warning about the missing include. |
paulbovbel
force-pushed
the
export-factories
branch
from
1e3af5f to
6b80573
Compare
|
Done |
|
|
|
Thanks for the improvement. |
dhananjaysathe
pushed a commit
to rapyuta-robotics/ros1_bridge
that referenced
this pull request
Aug 22, 2019
Signed-off-by: Dhananjay Sathe <dhananjay.sathe@rapyuta-robotics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose libros1_bridge functions via headers