Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note in documentation about rostopic echo #202

Merged
merged 1 commit into from
May 28, 2019

Conversation

mabelzhang
Copy link
Contributor

Adding a clarification in documentation, because @clalancette and I think rostopic echo is an obvious first thing that everyone starting to use the bridge would try, that there should be solid documentation so that people have the correct expectation that they need an actual subscriber, not just echo and decide the bridge doesn't work for them, which we saw happen.

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@mabelzhang mabelzhang marked this pull request as ready for review May 28, 2019 20:56
@dirk-thomas dirk-thomas merged commit c0e8236 into ros2:master May 28, 2019
dhananjaysathe pushed a commit to rapyuta-robotics/ros1_bridge that referenced this pull request Aug 22, 2019
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Dhananjay Sathe <dhananjay.sathe@rapyuta-robotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants