Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearer instructions for example ros1->ros2 #211

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Clearer instructions for example ros1->ros2 #211

merged 1 commit into from
Aug 13, 2019

Conversation

jlblancoc
Copy link
Contributor

Related to #205. I also found the instructions unclear about which ROS versions one has to source to run the bridge, so the proposal is to make it clearer.

@jlblancoc
Copy link
Contributor Author

Agreed DCO after opening the PR... probably you can re-run the check? if not, feel free of closing and re-opening a new one. Cheers

dirk-thomas
dirk-thomas reviewed Aug 12, 2019
View reviewed changes
README.md Outdated
@@ -107,7 +107,7 @@ You will get errors from most tools if they have both workspaces in their enviro
First we start a ROS 1 `roscore`:

```
# Shell A:
# Shell A (ROS1 only):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a space between ROS and the major version number.

Same below multiple times.

@dirk-thomas
Copy link
Member

Agreed DCO after opening the PR... probably you can re-run the check?

Actually you have to update the commit message to contain the line Signed-off-by: ... (see https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#pull-requests). You can fix the existing commit with git commit --amend -s and then force push that change to your branch: git push -f. The DCO check will pass.

@dirk-thomas dirk-thomas added enhancement New feature or request in progress Actively being worked on (Kanban column) labels Aug 12, 2019
@jlblancoc
Clearer instructions for example
97fc620 
Related to #205

Signed-off-by: Jose Luis Blanco Claraco <joseluisblancoc@gmail.com>
@jlblancoc
Copy link
Contributor Author

Oh, sure! Didn't quite understood the purpose of the DCO app.
Done now. Thanks @dirk-thomas .

@dirk-thomas dirk-thomas removed the in progress Actively being worked on (Kanban column) label Aug 13, 2019
@dirk-thomas
Copy link
Member

Thanks for the improvement.

@dirk-thomas dirk-thomas merged commit b21de05 into ros2:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlblancoc @dirk-thomas