Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use launch_testing features that will be deprecated #222

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

pbaughman
Copy link
Contributor

Removing some of the 'magic' features from launch_testing that we want to deprecate.

For background, see ros2/launch#346

Signed-off-by: Pete Baughman pete.baughman@apex.ai

Signed-off-by: Pete Baughman <pete.baughman@apex.ai>
@sloretz
Copy link
Contributor

sloretz commented Oct 21, 2019

CI (testing just ros1_bridge on linux)
Build Status (java traceback)
Build Status

@sloretz
Copy link
Contributor

sloretz commented Oct 21, 2019

CI looks good. Unstable due to

--- stderr: ros1_bridge
12:47:04 CMake Warning at /home/jenkins-agent/workspace/ci_packaging_linux/ws/install/share/actionlib_msgs/cmake/actionlib_msgsConfig.cmake:29 (message):
12:47:04   Package 'actionlib_msgs' is deprecated (This package will be removed in a
12:47:04   future ROS distro, once the ROS 1 bridge supports actions.)
12:47:04 Call Stack (most recent call first):
12:47:04   CMakeLists.txt:94 (find_package)
12:47:04 
12:47:04 
12:47:04 ---
12:47:04 Finished <<< ros1_bridge [22min 20s]
12:47:04 
12:47:04 Summary: 1 package finished [22min 22s]
12:47:04   1 package had stderr output: ros1_bridge
12:47:04 
12:47:04 # END SUBSECTION

@sloretz sloretz requested a review from mjcarroll October 21, 2019 21:21
Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, actionlib_msgs deprecation warning is expected (and happens on nightly)

@sloretz sloretz merged commit 94561bf into ros2:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants