Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example for parameter_bridge #330

Merged
merged 6 commits into from
Oct 18, 2021
Merged

Example for parameter_bridge #330

merged 6 commits into from
Oct 18, 2021

Conversation

LoyVanBeek
Copy link
Contributor

No description provided.

@LoyVanBeek
Add example for using the parameter_bridge
9dfd3c5 
WIP: Need to flesh out the example a bit more in same style as rest of README but basics are in place

Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
@LoyVanBeek
Document fields in services_1_to_2 param elems
9cc7e51 
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
@LoyVanBeek
Elaborate on parameter_bridge example
db01810 
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
@LoyVanBeek
Small fixups to parameter_bridge tutorial
75dc9eb 
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
@LoyVanBeek
Add some example output
d54d67c 
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
@LoyVanBeek LoyVanBeek force-pushed the example-for-parameter_bridge branch from f195bf3 to d54d67c Compare October 11, 2021 09:36
@LoyVanBeek LoyVanBeek marked this pull request as ready for review October 11, 2021 09:41
fujitatomoya
fujitatomoya approved these changes Oct 11, 2021
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is really nice to add.

@mhl787156 mhl787156 mentioned this pull request Oct 12, 2021
Merged
1 task
@LoyVanBeek LoyVanBeek mentioned this pull request Oct 18, 2021
Merged
@LoyVanBeek LoyVanBeek changed the title Example for parameter bridge Example for parameter_bridge Oct 18, 2021
@LoyVanBeek
Copy link
Contributor Author

What else can I do to get this merged?

@clalancette
Minor edits
ddecca5 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette force-pushed the example-for-parameter_bridge branch from 85a80e7 to ddecca5 Compare October 18, 2021 12:22
@clalancette clalancette merged commit 6979cea into ros2:master Oct 18, 2021
@LoyVanBeek LoyVanBeek deleted the example-for-parameter_bridge branch October 18, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LoyVanBeek @clalancette @fujitatomoya