print bridged type names #96
Conversation
include/ros1_bridge/factory.hpp
Outdated
| : ros1_type_name_(ros1_type_name), | ||
| ros2_type_name_(ros2_type_name) | ||
| { | ||
| fprintf(stderr, "Factory(%s, %s)\n", ros1_type_name_.c_str(), ros2_type_name_.c_str()); |
There was a problem hiding this comment.
Should this be left in or removed?
There was a problem hiding this comment.
Good catch. I removed the debug output.
| _ros1_bridge_type_to_name(ROS2_T) " (showing msg only once per type)"); | ||
| "ros1_bridge", | ||
| "Passing message from ROS 1 %s to ROS 2 %s (showing msg only once per type)", | ||
| ros1_type_name.c_str(), ros2_type_name.c_str()); |
There was a problem hiding this comment.
Would be nice if this included the topic it was doing this on.
There was a problem hiding this comment.
I was only aiming to fix the bug with this. Please feel free to extend the patch to add additional information.
There was a problem hiding this comment.
Should we wait for this to be updated or merge it as-is and make additional improvements in a separate PR?
There was a problem hiding this comment.
You can merge it as is, I’ll open another pr if I have a minute to add the topic name.
There was a problem hiding this comment.
You can merge it as is, I’ll open another pr if I have a minute to add the topic name.
| _ros1_bridge_type_to_name(ROS1_T) " (showing msg only once per type)"); | ||
| "ros1_bridge", | ||
| "Passing message from ROS 2 %s to ROS 1 %s (showing msg only once per type)", | ||
| ros1_type_name.c_str(), ros2_type_name.c_str()); |
dirk-thomas
force-pushed
the
print_type_names
branch
from
ebe9d2b to
a439f50
Compare
Fixes #95.