-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Fast CDR to 2.2.x #1530
Conversation
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@clalancette friendly ping here |
@MiguelCompany Out of curiosity. |
Also, another question is whether they are backward compatible. |
Apart from the changes explained here, methods where changed from
The serialization algorithm is the same if the Cdr object is constructed with |
Apologies. We are frantically trying to get Rolling working on Ubuntu 24.04. Once the dust settles on that, I'll take a look at this set of patches. |
Another round of CI after ros2/rosidl_typesupport_fastrtps#114 (comment) |
New CI after ros2/rmw_fastrtps#746 (comment) |
@clalancette it seems my repos file is outdated and you should not use it for CI |
Oops, yeah. Here is a new one, with my updated repos file: CI: |
@MiguelCompany @EduPonz It looks like RHEL-9 builds are failing because the new version of Fast-CDR currently requires CMake 3.22, whereas RHEL-9 only has CMake 3.20. Can you take a look? |
I've opened eProsima/Fast-CDR#204 to avoid building Fast CDR test if the minimum required CMake is not met. |
@clalancette eProsima/Fast-CDR#204 was merged. I think we can keep going on this one |
All of the failures here are unrelated. So I'm going to go ahead and merge this one and the dependencies in. Thanks for the work here! |
This PR updates Fast CDR to 2.2.x
The following PRs update the dependent packages to deal with the API breaks from Fast CDR v1 to v2,
and should be merged along with this one:
For simplicity, I have prepared this repos file with which we have tested the changes