Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Using parameters in a class" tutorials having inconsistent node names #729

Closed
jacobperron opened this issue Jun 1, 2020 · 1 comment · Fixed by #2865
Closed

"Using parameters in a class" tutorials having inconsistent node names #729

jacobperron opened this issue Jun 1, 2020 · 1 comment · Fixed by #2865
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jacobperron
Copy link
Member

jacobperron commented Jun 1, 2020

This is more of a nitpick, but the default names of the nodes in the parameter class tutorials are inconsistent. The C++ tutorials uses the name parameter_node and the Python tutorial uses the name param_talker.

I think the names should either be the same or follow the same pattern (i.e. both have the suffix _node or _talker).

Note, I noticed the inconsistency when adapting the launch file from the C++ tutorial that is referenced by the Python tutorial.

Links to tutorials:

@jacobperron jacobperron added the enhancement New feature or request label Jun 1, 2020
@sloretz sloretz added the help wanted Extra attention is needed label Jun 18, 2020
@MorphyCao
Copy link

Based on foxy version:
In C++ the node name is "parameter_node"
In Python the node name is 'minimal_param_node'
I guess this is not a big issue, but agree to make them consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants