You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is more of a nitpick, but the default names of the nodes in the parameter class tutorials are inconsistent. The C++ tutorials uses the name parameter_node and the Python tutorial uses the name param_talker.
I think the names should either be the same or follow the same pattern (i.e. both have the suffix _node or _talker).
Note, I noticed the inconsistency when adapting the launch file from the C++ tutorial that is referenced by the Python tutorial.
Based on foxy version:
In C++ the node name is "parameter_node"
In Python the node name is 'minimal_param_node'
I guess this is not a big issue, but agree to make them consistent
This is more of a nitpick, but the default names of the nodes in the parameter class tutorials are inconsistent. The C++ tutorials uses the name
parameter_node
and the Python tutorial uses the nameparam_talker
.I think the names should either be the same or follow the same pattern (i.e. both have the suffix
_node
or_talker
).Note, I noticed the inconsistency when adapting the launch file from the C++ tutorial that is referenced by the Python tutorial.
Links to tutorials:
The text was updated successfully, but these errors were encountered: