Intermediate launch tutorial #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audrow
requested changes
Oct 11, 2021
There was a problem hiding this comment.
Looks pretty good.
Some high level feedback:
- Think about where you will end paragraphs. In general, I think of one paragraph as one idea. It should be fairly self-contained. I've advised combining several paragraphs.
- Make sure to be clear about parameters and arguments. In some sections it seems that they are used interchangeably, but they are different.
- Lastly, this PR seemed to have more grammar mistakes and typos than some of your previous PRs. Make sure to give it a proofread before marking the PR as ready for review.
That being said, overall the content is really good. Thanks for putting this together!
source/Tutorials/Launch-Files/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Launch-Files/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Launch-Files/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Launch-Files/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Launch-Files/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Launch-Files/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Launch-Files/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Launch-Files/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Launch-Files/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Launch-Files/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
|
I have now included some more content covering basics of using namespaces and wildcards. However, this tutorial does not go into a lot of details and tries to cover as much content as possible. More in depth tutorials could definitively be helpful, especially the one covering more wildcard syntax like |
ahcorde
approved these changes
Oct 13, 2021
source/Tutorials/Launch-Files/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
audrow
requested changes
Oct 13, 2021
source/Tutorials/Launch-Files/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Launch-Files/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Launch-Files/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
|
|
||
| .. code-block:: YAML | ||
|
|
||
| /**: |
There was a problem hiding this comment.
It would also be good to show how to use the wildcard operator to set parameters for a subset of nodes (which I think is possible). For example, something like, /turtles/**, which would apply to nodes in the /turtles namespace.
There was a problem hiding this comment.
I have omitted that for a time being as it currently does not work as expected. I tried to use that /**/sim phrase, but it is not working. I mentioned my case here: ros2/design#303 (comment)
I believe also that design features are not yet fully defined as some related PRs and issues are still open ros2/rclcpp#1265 (comment).
Otherwise, do you know the way to make it work?
There was a problem hiding this comment.
This syntax could be added or covered in its own tutorial later as mentioned in #2002 (comment).
|
@mergify backport foxy galactic |
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2021
* launch code and initial tutorial structure * add more information about ROS parameters * add sections on remappings and rviz config * update section on env variables * update code descriptions * add results section * remove pipfile * add setup.py configuration instructions * add prerequisites section * restructure and enumerate sections * apply review suggestions * fix grammar * add section on using namespaces * add subsection on wildcards * instruct to create a new launch file instead of updating the existing * minor fix * add reference to Creating your first ROS 2 package tutorial * apply suggestions (cherry picked from commit 9a63591)
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2021
* launch code and initial tutorial structure * add more information about ROS parameters * add sections on remappings and rviz config * update section on env variables * update code descriptions * add results section * remove pipfile * add setup.py configuration instructions * add prerequisites section * restructure and enumerate sections * apply review suggestions * fix grammar * add section on using namespaces * add subsection on wildcards * instruct to create a new launch file instead of updating the existing * minor fix * add reference to Creating your first ROS 2 package tutorial * apply suggestions (cherry picked from commit 9a63591)
|
Command
Hey, I reacted but my real name is @Mergifyio |
audrow
pushed a commit
that referenced
this pull request
Oct 13, 2021
* launch code and initial tutorial structure * add more information about ROS parameters * add sections on remappings and rviz config * update section on env variables * update code descriptions * add results section * remove pipfile * add setup.py configuration instructions * add prerequisites section * restructure and enumerate sections * apply review suggestions * fix grammar * add section on using namespaces * add subsection on wildcards * instruct to create a new launch file instead of updating the existing * minor fix * add reference to Creating your first ROS 2 package tutorial * apply suggestions (cherry picked from commit 9a63591) Co-authored-by: kurshakuz <abilkasov@gmail.com>
audrow
pushed a commit
that referenced
this pull request
Oct 13, 2021
* launch code and initial tutorial structure * add more information about ROS parameters * add sections on remappings and rviz config * update section on env variables * update code descriptions * add results section * remove pipfile * add setup.py configuration instructions * add prerequisites section * restructure and enumerate sections * apply review suggestions * fix grammar * add section on using namespaces * add subsection on wildcards * instruct to create a new launch file instead of updating the existing * minor fix * add reference to Creating your first ROS 2 package tutorial * apply suggestions (cherry picked from commit 9a63591) Co-authored-by: kurshakuz <abilkasov@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tutorial shows the way to use launch files for large projects. It also shows examples of using parameters, YAML files, remappings, namespaces, default arguments, and RViz configs in launch files.
Signed-off-by: Shyngyskhan Abilkassov abilkasov@gmail.com